Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33034: move GraphViz dot utilities to pipe_base #159

Closed
wants to merge 2 commits into from

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Dec 21, 2021

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

This PR is based on a temporary branch because its merge is blocked by DM-33027 (mostly because of changes in pipe_base, rather than here, but it's easier to keep things in sync this way). I'll rebase once DM-33027 lands.

Nothing to see here but code removal; that code reappears in the pipe_base PR for this ticket.

@timj
Copy link
Member

timj commented Sep 25, 2023

#158 did merge so does that mean we can now rebased this PR on main?

@TallJimbo
Copy link
Member Author

Yes, we can rebase now but I think conflicts are more likely than not.

@timj timj changed the base branch from u/jbosch/DM-33034/review-base to main September 27, 2023 16:32
@timj
Copy link
Member

timj commented Sep 27, 2023

Rebase of this one was easy.

@timj
Copy link
Member

timj commented Sep 27, 2023

(although one of the commits here seems out of place -- the expanded pipeline one)

@timj timj force-pushed the tickets/DM-33034 branch from 2ce429a to 001cf14 Compare August 8, 2024 21:52
@timj timj force-pushed the tickets/DM-33034 branch from 001cf14 to 846df10 Compare August 8, 2024 21:55
@timj
Copy link
Member

timj commented Aug 9, 2024

I see that in lsst/pipe_base#222 you state that the expanded pipeline part of the PR disappeared so maybe we drop that commit? I also see though that the pipe_base PR is quite large and is more than simply relocating dotTools. How about I move dotTools on a different ticket and then close this PR (dropping the expanded pipeline commit)?

@TallJimbo
Copy link
Member Author

Moving dotTools on a different ticket and then closing this PR sounds great. I don't really care about the pipe_base PR for this ticket either, but I do want to keep the pipe_base branch, as it's got useful stuff along with a lot of no-longer-useful stuff.

@timj
Copy link
Member

timj commented Aug 10, 2024

This is made obsolete by #300

@timj timj closed this Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants